Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2505683002: Update links to layout test documentation. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, blink-reviews, chromium-reviews, Dirk Pranke, feature-media-reviews_chromium.org, jbudorick+watch_chromium.org, jeffcarp, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update links to layout test documentation. BUG=665494 Committed: https://crrev.com/ac3af530807e91e53806ce9e38629f67c109af07 Cr-Commit-Position: refs/heads/master@{#432639}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update - remove "WebKit", remove "wiki". #

Total comments: 7

Patch Set 3 : Use relative paths in markdown, and src-relative paths elsewhere. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M docs/android_test_instructions.md View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M docs/how_to_extend_layout_test_framework.md View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M docs/layout_tests_linux.md View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M media/tools/layout_tests/bug.py View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M media/tools/layout_tests/test_expectations.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M testing/android/docs/README.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (13 generated)
qyearsley
This CL updates some links to layout test documentation after it was moved in https://codereview.chromium.org/2476573006 ...
4 years, 1 month ago (2016-11-15 17:57:27 UTC) #2
hubbe
media LGTM
4 years, 1 month ago (2016-11-15 18:14:04 UTC) #3
pwnall
Thank you very much for updating the links! LGTM with nits. https://codereview.chromium.org/2505683002/diff/1/docs/how_to_extend_layout_test_framework.md File docs/how_to_extend_layout_test_framework.md (right): ...
4 years, 1 month ago (2016-11-15 18:23:11 UTC) #4
qyearsley
Now updated after pwnall's comments :-) jbudorick@, could you review the change in testing/android/docs/README.md? https://codereview.chromium.org/2505683002/diff/1/docs/how_to_extend_layout_test_framework.md ...
4 years, 1 month ago (2016-11-15 19:04:57 UTC) #6
jbudorick
On 2016/11/15 19:04:57, qyearsley wrote: > Now updated after pwnall's comments :-) > > jbudorick@, ...
4 years, 1 month ago (2016-11-15 19:13:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505683002/20001
4 years, 1 month ago (2016-11-15 19:30:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/260850)
4 years, 1 month ago (2016-11-15 19:43:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505683002/20001
4 years, 1 month ago (2016-11-15 22:14:24 UTC) #14
Dirk Pranke
You should prefer relative URLs and source-relative path references where possible. That way they'll refer ...
4 years, 1 month ago (2016-11-15 22:24:55 UTC) #16
qyearsley
On 2016/11/15 at 22:24:55, dpranke wrote: > You should prefer relative URLs and source-relative path ...
4 years, 1 month ago (2016-11-15 23:42:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505683002/40001
4 years, 1 month ago (2016-11-16 00:17:22 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/338095)
4 years, 1 month ago (2016-11-16 00:53:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505683002/40001
4 years, 1 month ago (2016-11-16 21:56:52 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 22:08:08 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 22:13:57 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac3af530807e91e53806ce9e38629f67c109af07
Cr-Commit-Position: refs/heads/master@{#432639}

Powered by Google App Engine
This is Rietveld 408576698