Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2505673002: Observatory: remove unused imports (Closed)

Created:
4 years, 1 month ago by kevmoo
Modified:
4 years, 1 month ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M runtime/observatory/lib/repositories.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/issue_27238_test.dart View 1 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/issue_27287_test.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/reload_sources_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kevmoo
4 years, 1 month ago (2016-11-15 17:46:45 UTC) #2
Cutch
you broke the tests. Please run $ ./tools/test.py service https://codereview.chromium.org/2505673002/diff/1/runtime/observatory/tests/service/issue_27238_test.dart File runtime/observatory/tests/service/issue_27238_test.dart (right): https://codereview.chromium.org/2505673002/diff/1/runtime/observatory/tests/service/issue_27238_test.dart#newcode11 runtime/observatory/tests/service/issue_27238_test.dart:11: ...
4 years, 1 month ago (2016-11-15 22:17:12 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/2505673002/diff/1/runtime/observatory/tests/service/issue_27238_test.dart File runtime/observatory/tests/service/issue_27238_test.dart (right): https://codereview.chromium.org/2505673002/diff/1/runtime/observatory/tests/service/issue_27238_test.dart#newcode11 runtime/observatory/tests/service/issue_27238_test.dart:11: const int LINE_A = 20; On 2016/11/15 22:17:12, ...
4 years, 1 month ago (2016-11-15 23:00:36 UTC) #4
Cutch
lgtm
4 years, 1 month ago (2016-11-15 23:06:00 UTC) #5
kevmoo
4 years, 1 month ago (2016-11-15 23:11:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4e17c8b1f876a8084e222afae8f07350c7a20f94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698