Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2505653002: [Devtools] Added "is:from-cache" filter to network (Closed)
Patch Set: Merge remote-tracking branch 'origin/master' into IS_FROM_CACHE Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 091ba51c8ea0addcf488bdb480ce035674bf26ef..bef3c6f504ac793ec90178cfaca1cd0980225cc4 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -182,6 +182,14 @@ Network.NetworkLogView = class extends UI.VBox {
}
/**
+ * @param {!SDK.NetworkRequest} request
+ * @return {boolean}
+ */
+ static _fromCacheRequestFilter(request) {
+ return request.cached();
+ }
+
+ /**
* @param {string} value
* @param {!SDK.NetworkRequest} request
* @return {boolean}
@@ -429,6 +437,8 @@ Network.NetworkLogView = class extends UI.VBox {
_resetSuggestionBuilder() {
this._suggestionBuilder = new Network.FilterSuggestionBuilder(Network.NetworkLogView._searchKeys);
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.Is, Network.NetworkLogView.IsFilterType.Running);
+ this._suggestionBuilder.addItem(
+ Network.NetworkLogView.FilterType.Is, Network.NetworkLogView.IsFilterType.FromCache);
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.LargerThan, '100');
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.LargerThan, '10k');
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.LargerThan, '1M');
@@ -1403,6 +1413,8 @@ Network.NetworkLogView = class extends UI.VBox {
case Network.NetworkLogView.FilterType.Is:
if (value.toLowerCase() === Network.NetworkLogView.IsFilterType.Running)
return Network.NetworkLogView._runningRequestFilter;
+ if (value.toLowerCase() === Network.NetworkLogView.IsFilterType.FromCache)
+ return Network.NetworkLogView._fromCacheRequestFilter;
break;
case Network.NetworkLogView.FilterType.LargerThan:
@@ -1683,7 +1695,8 @@ Network.NetworkLogView.MixedContentFilterValues = {
/** @enum {string} */
Network.NetworkLogView.IsFilterType = {
- Running: 'running'
+ Running: 'running',
+ FromCache: 'from-cache'
};
/** @type {!Array<string>} */
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698