[NaCl SDK] Add initial support for google drive to nacl_io

[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/43bfb9dc37a9930a33e4c8eb7f05f0e314be7149
Cr-Commit-Position: refs/heads/master@{#433181}

[chanpatorikku, 2016-11-15 14:35:13]

Patchset #1 (id:1) has been deleted

[chanpatorikku, 2016-11-15 14:39:13]

Description was changed from

==========
[NaCl SDK] Wire up the basic class structure of GoogleDriveFs and
GoogleDriveFsNode

Declare GoogleDriveFs and GoogleDriveFsNode.
Wire GoogleDriveFs to Filesystem, TypedFsFactory, and KernelProxy.
Wire GoogleDriveFsNode to Node.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy.  It was run in googledrivefs.{cc,h} and
googledrivefs_node.{cc,h}.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Wire up the basic class structures of GoogleDriveFs and
GoogleDriveFsNode

Declare GoogleDriveFs and GoogleDriveFsNode.
Wire GoogleDriveFs to Filesystem, TypedFsFactory, and KernelProxy.
Wire GoogleDriveFsNode to Node.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy.  It was run in googledrivefs.{cc,h} and
googledrivefs_node.{cc,h}.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-15 15:10:15]

Patchset #1 (id:20001) has been deleted

[chanpatorikku, 2016-11-15 15:10:44]

chanpatorikku@gmail.com changed reviewers:
+ binji@chromium.org, sbc@chromium.org

[chanpatorikku, 2016-11-15 15:10:45]

ptal

[Sam Clegg, 2016-11-15 15:54:54]

So I assume you have implementations for these methods that will be part of a
followup CL?  We might have got too far in splitting up the work at this point
since if this CL lands we will have unused/untested code in the codebase.  Are
the implementations and tests very large?  Can you link to the followup CL so I
can take a look?

I would re-phrase the CL description.  Perhaps replace "Wire up..." with "Add
initial support for google drive to nacl_io".

No need to mention clang-format in the CL description here since its all new
code.

[chanpatorikku, 2016-11-15 16:55:49]

Description was changed from

==========
[NaCl SDK] Wire up the basic class structures of GoogleDriveFs and
GoogleDriveFsNode

Declare GoogleDriveFs and GoogleDriveFsNode.
Wire GoogleDriveFs to Filesystem, TypedFsFactory, and KernelProxy.
Wire GoogleDriveFsNode to Node.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy.  It was run in googledrivefs.{cc,h} and
googledrivefs_node.{cc,h}.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.
Wire GoogleDriveFs to Filesystem, TypedFsFactory, and KernelProxy.
Wire GoogleDriveFsNode to Node.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-15 17:17:09]

On 2016/11/15 15:54:54, Sam Clegg wrote:
> So I assume you have implementations for these methods that will be part of a
> followup CL?  We might have got too far in splitting up the work at this point
> since if this CL lands we will have unused/untested code in the codebase.  

Yes.  Implementations for methods that will be part of followup CL's exist.

Multiple CL's, instead of of one CL, are going to be requested for reviews. 
Additional functionality is going to be added piece-by-piece.

I don't quite see how the code can be changed from unused to used.

Could you please reply if similar to html5_fs_test.cc, adding a Google Test
fixture class GoogleDriveFsTest, adding a class GoogleDriveFsForTesting that
extends GoogleDriveFs, and adding a Google Test test case in a new file in
nacl_io_test are going to make the codes in patch set 1 become used?

> Are the implementations and tests very large?  

The implementations are tests are about 4000 lines total for all
functionalities.

Ben (binji) took about a few hours to go through the codes.

> Can you link to the followup CL so I
> can take a look?
> 

Yes. https://codereview.chromium.org/2156503002/

The amount of information is a lot.  You probably are better to ask me more
things for any concerns so your time can be minimized in this review and more
time is spent on your primary work.

> I would re-phrase the CL description.  Perhaps replace "Wire up..." with "Add
> initial support for google drive to nacl_io".
>

Done.
 
> No need to mention clang-format in the CL description here since its all new
> code.

Done.

[chanpatorikku, 2016-11-17 12:42:43]

When youre not busy, could you please reply what you plan to re-view the code
and the future code that their are a lot of lines?

[Sam Clegg, 2016-11-17 17:40:02]

On 2016/11/17 12:42:43, chanpatorikku wrote:
> When youre not busy, could you please reply what you plan to re-view the code
> and the future code that their are a lot of lines?

What do you think binji?  Is this a sensible incremental step?

I would at least mention in the CL that this just scaffolding code and that the
implementation and tests are coming later.

[binji, 2016-11-17 18:22:40]

lgtm

I don't think this is too incremental, I like that it is clear exactly what this
CL is doing (just adding the scaffolding).

[chanpatorikku, 2016-11-18 03:57:10]

Description was changed from

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.
Wire GoogleDriveFs to Filesystem, TypedFsFactory, and KernelProxy.
Wire GoogleDriveFsNode to Node.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the
implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-18 03:57:53]

Description was changed from

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the
implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-18 03:58:21]

The CQ bit was checked by chanpatorikku@gmail.com

[commit-bot: I haz the power, 2016-11-18 03:59:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 05:39:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chanpatorikku, 2016-11-18 11:11:33]

The CQ bit was checked by chanpatorikku@gmail.com

[commit-bot: I haz the power, 2016-11-18 11:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 11:46:04]

Description was changed from

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[commit-bot: I haz the power, 2016-11-18 11:46:05]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-11-18 11:48:20]

Description was changed from

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs 
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are 
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Add initial support for google drive to nacl_io

Declare GoogleDriveFs and GoogleDriveFsNode.  Wire GoogleDriveFs
to Filesystem, TypedFsFactory, and KernelProxy.  Wire GoogleDriveFsNode
to Node.

This is just scaffolding code and the implementation and tests are
coming later.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/43bfb9dc37a9930a33e4c8eb7f05f0e314be7149
Cr-Commit-Position: refs/heads/master@{#433181}
==========

[commit-bot: I haz the power, 2016-11-18 11:48:21]

Patchset 1 (id:??) landed as
https://crrev.com/43bfb9dc37a9930a33e4c8eb7f05f0e314be7149
Cr-Commit-Position: refs/heads/master@{#433181}