third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp - Issue 2505543004: Let querySelector(All) match (nth-)last with unclosed parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

Issue 2505543004: Let querySelector(All) match (nth-)last with unclosed parent. (Closed)

Patch Set: Added expectation file Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp b/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

index 7c82d08268d3d0989ffb9ffd8d13fb2bcb1ce532..08bdb3565fd04e953f5d46a787dd43a299ece458 100644

--- a/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

@@ -6,6 +6,7 @@

#include "core/css/parser/CSSParser.h"

#include "core/dom/Document.h"

+#include "core/html/HTMLDocument.h"

#include "core/html/HTMLHtmlElement.h"

#include "testing/gtest/include/gtest/gtest.h"

#include <memory>

@@ -34,4 +35,22 @@ TEST(SelectorQueryTest, NotMatchingPseudoElement) {

EXPECT_NE(nullptr, elm);

}

+TEST(SelectorQueryTest, LastOfTypeNotFinishedParsing) {

+ Document* document = HTMLDocument::create();

+ HTMLHtmlElement* html = HTMLHtmlElement::create(*document);

+ document->appendChild(html);

+ document->documentElement()->setInnerHTML(

+ "<body><p></p><p id=last></p></body>", ASSERT_NO_EXCEPTION);

+ document->body()->beginParsingChildren();

+ CSSSelectorList selectorList = CSSParser::parseSelector(

+ CSSParserContext(*document, nullptr), nullptr, "p:last-of-type");

+ std::unique_ptr<SelectorQuery> query =

+ SelectorQuery::adopt(std::move(selectorList));

+ Element* elm = query->queryFirst(*document);

+ ASSERT_TRUE(elm);

+ EXPECT_EQ("last", elm->idForStyleResolution());

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/css/SelectorChecker.cpp ('k') | no next file » | no next file with comments »