Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2505533003: 📰 Make NTP Tiles show download link when appropriate (Closed)

Created:
4 years, 1 month ago by dgn
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Make NTP Tiles show download link when appropriate BUG=665119 Committed: https://crrev.com/3c4159d37be5f16172c6f97ec5a210ebe39579c3 Cr-Commit-Position: refs/heads/master@{#432515}

Patch Set 1 #

Total comments: 3

Patch Set 2 : reupload #

Total comments: 2

Patch Set 3 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java View 1 2 4 chunks +11 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dgn
PTAL
4 years, 1 month ago (2016-11-15 16:49:27 UTC) #3
dgn
https://codereview.chromium.org/2505533003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java (right): https://codereview.chromium.org/2505533003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java#newcode54 chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:54: String getUrl(); null will be returned for the status ...
4 years, 1 month ago (2016-11-15 16:49:55 UTC) #4
Bernhard Bauer
Can you reupload the patch set? SnippetArticleViewHolder.java seems to be corrupted. https://codereview.chromium.org/2505533003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java (right): ...
4 years, 1 month ago (2016-11-15 16:59:07 UTC) #5
dgn
PTAL https://codereview.chromium.org/2505533003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java (right): https://codereview.chromium.org/2505533003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java#newcode91 chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java:91: public String getUrl() { On 2016/11/15 16:59:07, Bernhard ...
4 years, 1 month ago (2016-11-16 10:47:18 UTC) #6
Bernhard Bauer
lgtm https://codereview.chromium.org/2505533003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java (right): https://codereview.chromium.org/2505533003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java#newcode80 chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:80: { Move this on the previous line.
4 years, 1 month ago (2016-11-16 15:25:48 UTC) #7
dgn
Thanks! https://codereview.chromium.org/2505533003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java (right): https://codereview.chromium.org/2505533003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java#newcode80 chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:80: { On 2016/11/16 15:25:48, Bernhard Bauer wrote: > ...
4 years, 1 month ago (2016-11-16 15:54:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505533003/40001
4 years, 1 month ago (2016-11-16 15:55:11 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 16:40:56 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 16:44:40 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3c4159d37be5f16172c6f97ec5a210ebe39579c3
Cr-Commit-Position: refs/heads/master@{#432515}

Powered by Google App Engine
This is Rietveld 408576698