Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2505533002: Http Bad: Add "Learn more" sublabel to warning message and make it clickable (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index d7e7cfcf3e2bb6bb3f98cf20f8441a302e74f6fc..7f1e87df225052bdefb8634cb8312ea8128c883b 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -576,10 +576,11 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
// On top of the explanation message, first show a "Payment not secure"
// message.
if (IsCreditCardAutofillHttpWarningEnabled()) {
- Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
- IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
- cc_field_http_warning_suggestion.frontend_id =
- POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
+ Suggestion cc_field_http_warning_suggestion(
+ l10n_util::GetStringUTF8(
+ IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE),
+ l10n_util::GetStringUTF8(IDS_AUTOFILL_HTTP_WARNING_LEARN_MORE),
+ "", POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE);
suggestions.insert(suggestions.begin(),
cc_field_http_warning_suggestion);
}
@@ -1071,6 +1072,10 @@ bool AutofillManager::ShouldUploadForm(const FormStructure& form) {
kRequiredFieldsForFormsWithOnlyPasswordFields));
}
+void AutofillManager::OpenUrl(const GURL& url) {
+ client_->OpenUrl(url);
+}
+
void AutofillManager::ImportFormData(const FormStructure& submitted_form) {
std::unique_ptr<CreditCard> imported_credit_card;
if (!personal_data_->ImportFormData(

Powered by Google App Engine
This is Rietveld 408576698