Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 250553005: Added an Isolate* field to NoTrackDoubleFieldsForSerializerScope, PlatformFeatureScope and BinaryOp… (Closed)

Created:
6 years, 8 months ago by Sven Panne
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Added an Isolate* field to NoTrackDoubleFieldsForSerializerScope, PlatformFeatureScope and BinaryOpIC::State. The serializer state and even the CPU features will be per-Isolate later. Currently we get away with global state, because mksnapshot runs single-threaded and has only 1 Isolate, but this will change. Furthermore, these changes are yet another prerequisite for removing a catch-22 at initialization time when we try to enable serialization. This CL is similar in spirit to r20919, BTW. BUG=359977 LOG=y R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20963

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback. Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/ic.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M src/type-info.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
Yet another spin-off from a bigger CL to get the startup right...
6 years, 8 months ago (2014-04-24 13:10:49 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/250553005/diff/1/src/ic.h File src/ic.h (right): https://codereview.chromium.org/250553005/diff/1/src/ic.h#newcode746 src/ic.h:746: explicit State(Isolate* isolate, ExtraICState extra_ic_state); nit: No longer ...
6 years, 8 months ago (2014-04-25 08:03:29 UTC) #2
Sven Panne
Feedback addressed, landing... https://codereview.chromium.org/250553005/diff/1/src/ic.h File src/ic.h (right): https://codereview.chromium.org/250553005/diff/1/src/ic.h#newcode746 src/ic.h:746: explicit State(Isolate* isolate, ExtraICState extra_ic_state); On ...
6 years, 8 months ago (2014-04-25 08:27:08 UTC) #3
Sven Panne
6 years, 8 months ago (2014-04-25 08:40:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698