Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2505483003: Plugin Power Saver: Re-enable OriginWhitelisting browser test on ASan. (Closed)

Created:
4 years, 1 month ago by tommycli
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Re-enable OriginWhitelisting browser test on ASan. The underlying issue should have been fixed. See the bug. We just forgot to re-enable this test. BUG=560765 Committed: https://crrev.com/790f0f6b573f8a63c03e51518a610db671b54214 Cr-Commit-Position: refs/heads/master@{#432508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tommycli
dpapad: PTAL, thanks!
4 years, 1 month ago (2016-11-15 23:02:51 UTC) #3
dpapad
lgtm
4 years, 1 month ago (2016-11-15 23:04:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505483003/1
4 years, 1 month ago (2016-11-15 23:05:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261315)
4 years, 1 month ago (2016-11-15 23:25:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505483003/1
4 years, 1 month ago (2016-11-16 15:43:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:15:55 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 16:19:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/790f0f6b573f8a63c03e51518a610db671b54214
Cr-Commit-Position: refs/heads/master@{#432508}

Powered by Google App Engine
This is Rietveld 408576698