Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2505483002: Also push process_test when testing on Android hardware. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 7b1e5965389c7abc8ae48df392892cb83701b83c..f9d7b998686646a48055c9a790d396d8de41f1e6 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -364,12 +364,16 @@ class VmCommand extends ProcessCommand {
class AdbPrecompilationCommand extends Command {
final String precompiledRunnerFilename;
+ final String processTestFilename;
final String precompiledTestDirectory;
final List<String> arguments;
final bool useBlobs;
AdbPrecompilationCommand._(this.precompiledRunnerFilename,
- this.precompiledTestDirectory, this.arguments, this.useBlobs)
+ this.processTestFilename,
+ this.precompiledTestDirectory,
+ this.arguments,
+ this.useBlobs)
: super._("adb_precompilation");
void _buildHashCode(HashCodeBuilder builder) {
@@ -698,9 +702,12 @@ class CommandBuilder {
}
AdbPrecompilationCommand getAdbPrecompiledCommand(String precompiledRunner,
- String testDirectory, List<String> arguments, bool useBlobs) {
+ String processTest,
+ String testDirectory,
+ List<String> arguments,
+ bool useBlobs) {
var command = new AdbPrecompilationCommand._(
- precompiledRunner, testDirectory, arguments, useBlobs);
+ precompiledRunner, processTest, testDirectory, arguments, useBlobs);
return _getUniqueCommand(command);
}
@@ -2638,6 +2645,7 @@ class CommandExecutorImpl implements CommandExecutor {
Future<CommandOutput> _runAdbPrecompilationCommand(
AdbDevice device, AdbPrecompilationCommand command, int timeout) async {
var runner = command.precompiledRunnerFilename;
+ var processTest = command.processTestFilename;
var testdir = command.precompiledTestDirectory;
var arguments = command.arguments;
var devicedir = '/data/local/tmp/precompilation-testing';
@@ -2663,8 +2671,10 @@ class CommandExecutorImpl implements CommandExecutor {
// timing).
steps.add(() => device.runAdbCommand(
['push', runner, '$devicedir/dart_precompiled_runtime']));
+ steps.add(() => device.runAdbCommand(
+ ['push', processTest, '$devicedir/process_test']));
steps.add(() => device.runAdbShellCommand(
- ['chmod', '777', '$devicedir/dart_precompiled_runtime']));
+ ['chmod', '777', '$devicedir/dart_precompiled_runtime $devicedir/process_test']));
for (var file in files) {
steps.add(() => device
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698