Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5881e9b3bc7c96dc8a0d5ec823078e3b4d80a85c
Cr-Commit-Position: refs/heads/master@{#432073}

[Zhenyao Mo, 2016-11-15 01:15:04]

Description was changed from

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases
R=kbr@chromium.org
==========

to

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-11-15 01:15:39]

Description was changed from

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases. content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-11-15 01:16:25]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:17:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-11-15 01:18:34]

Description was changed from

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases. content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-15 01:25:15]

This is a great reliability improvement for testing. LGTM

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:354: // side.
Would other GPU acceleration features also be good candidates for this handling?
If so should we add a TODO about re-evaluating them?

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private_unittest.cc (right):

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private_unittest.cc:244:
EXPECT_TRUE(manager->GpuAccessAllowed(&reason));
Presumably this would have returned false before your change?

https://codereview.chromium.org/2505473002/diff/1/gpu/config/gpu_util_unittes...
File gpu/config/gpu_util_unittest.cc (left):

https://codereview.chromium.org/2505473002/diff/1/gpu/config/gpu_util_unittes...
gpu/config/gpu_util_unittest.cc:59: }
Does your new test provide all the coverage you feel necessary for the removal
of this test?

[Zhenyao Mo, 2016-11-15 01:38:21]

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:354: // side.
On 2016/11/15 01:25:14, Ken Russell wrote:
> Would other GPU acceleration features also be good candidates for this
handling?
> If so should we add a TODO about re-evaluating them?

Might be.  Good point. Added.

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private_unittest.cc (right):

https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private_unittest.cc:244:
EXPECT_TRUE(manager->GpuAccessAllowed(&reason));
On 2016/11/15 01:25:15, Ken Russell wrote:
> Presumably this would have returned false before your change?

Yes, see above the GpuSideBlacklisting unit test.

https://codereview.chromium.org/2505473002/diff/1/gpu/config/gpu_util_unittes...
File gpu/config/gpu_util_unittest.cc (left):

https://codereview.chromium.org/2505473002/diff/1/gpu/config/gpu_util_unittes...
gpu/config/gpu_util_unittest.cc:59: }
On 2016/11/15 01:25:15, Ken Russell wrote:
> Does your new test provide all the coverage you feel necessary for the removal
> of this test?

The MergeFeatrure function is removed so there is no need for unittests.

[Zhenyao Mo, 2016-11-15 01:38:30]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-11-15 01:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2505473002/#ps20001
(title: "adding TODO")

[commit-bot: I haz the power, 2016-11-15 01:39:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:37:02]

Description was changed from

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-15 03:37:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 03:43:25]

Description was changed from

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser.

BUG=662170
TEST=media.tough_video_cases,content_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5881e9b3bc7c96dc8a0d5ec823078e3b4d80a85c
Cr-Commit-Position: refs/heads/master@{#432073}
==========

[commit-bot: I haz the power, 2016-11-15 03:43:26]

Patchset 2 (id:??) landed as
https://crrev.com/5881e9b3bc7c96dc8a0d5ec823078e3b4d80a85c
Cr-Commit-Position: refs/heads/master@{#432073}