Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2505473002: Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't forbid GPU process if WebGL/WebGL2 is disabled on GPU but not browser. BUG=662170 TEST=media.tough_video_cases,content_unittests R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5881e9b3bc7c96dc8a0d5ec823078e3b4d80a85c Cr-Commit-Position: refs/heads/master@{#432073}

Patch Set 1 #

Total comments: 6

Patch Set 2 : adding TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -56 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 chunks +18 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M gpu/config/gpu_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/config/gpu_util.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/config/gpu_util_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Ken Russell (switch to Gerrit)
This is a great reliability improvement for testing. LGTM https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode354 content/browser/gpu/gpu_data_manager_impl_private.cc:354: ...
4 years, 1 month ago (2016-11-15 01:25:15 UTC) #6
Zhenyao Mo
https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2505473002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode354 content/browser/gpu/gpu_data_manager_impl_private.cc:354: // side. On 2016/11/15 01:25:14, Ken Russell wrote: > ...
4 years, 1 month ago (2016-11-15 01:38:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505473002/20001
4 years, 1 month ago (2016-11-15 01:39:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 03:37:03 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 03:43:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5881e9b3bc7c96dc8a0d5ec823078e3b4d80a85c
Cr-Commit-Position: refs/heads/master@{#432073}

Powered by Google App Engine
This is Rietveld 408576698