Inline ParseFunctionWithPreParser into SkipFunction

Inline ParseFunctionWithPreParser into SkipFunction

BUG=

Committed: https://crrev.com/244a049bfcb905054fa096829662b60b4ad0bf57
Cr-Commit-Position: refs/heads/master@{#41003}

[Toon Verwaest, 2016-11-15 12:22:00]

verwaest@chromium.org changed reviewers:
+ vogelheim@chromium.org

[Toon Verwaest, 2016-11-15 12:22:00]

ptal

[vogelheim, 2016-11-15 16:14:10]

lgtm

https://codereview.chromium.org/2505453003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2505453003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2775:
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"), "V8.PreParse");
This is a scope, and will now cover a somewhat larger amount of work. I guess
that's intentional?

(The stuff after this is mostly trivial, except the produce_cached_parse_data()
might cost a bit of time. Arguably this new version is more accurate than the
old one... :)

[Toon Verwaest, 2016-11-15 16:18:12]

Yes. I did ponder putting it in a scope to keep the old behavior but it didn't
seem worthwhile.

[Toon Verwaest, 2016-11-15 16:18:30]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-11-15 16:18:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 16:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 16:19:48]

Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16201)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Toon Verwaest, 2016-11-15 16:23:45]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-11-15 16:23:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2505453003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-15 16:23:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-11-15 16:25:17]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-11-15 16:25:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2505453003/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2016-11-15 16:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 16:50:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:34:39]

Description was changed from

==========
Inline ParseFunctionWithPreParser into SkipFunction

BUG=
==========

to

==========
Inline ParseFunctionWithPreParser into SkipFunction

BUG=

Committed: https://crrev.com/244a049bfcb905054fa096829662b60b4ad0bf57
Cr-Commit-Position: refs/heads/master@{#41003}
==========

[commit-bot: I haz the power, 2016-11-17 22:34:42]

Patchset 3 (id:??) landed as
https://crrev.com/244a049bfcb905054fa096829662b60b4ad0bf57
Cr-Commit-Position: refs/heads/master@{#41003}