Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2505453002: Remove non-trivial static initializer (Closed)

Created:
4 years, 1 month ago by jrummell
Modified:
4 years, 1 month ago
Reviewers:
xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-trivial static initializer Even though this is test-only code, non-trivial static initializers aren't allowed in Chromium, so remove it. BUG=660376 TEST=EME browser_tests pass Committed: https://crrev.com/5871a5a23990bc54a90de839e62a36497025123d Cr-Commit-Position: refs/heads/master@{#432139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jrummell
PTAL
4 years, 1 month ago (2016-11-15 00:50:42 UTC) #3
xhwang
lgtm
4 years, 1 month ago (2016-11-15 07:12:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505453002/1
4 years, 1 month ago (2016-11-15 07:12:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 07:17:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 07:20:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5871a5a23990bc54a90de839e62a36497025123d
Cr-Commit-Position: refs/heads/master@{#432139}

Powered by Google App Engine
This is Rietveld 408576698