Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2505433002: Open link from WebUSB in the last used profile. (Closed)

Created:
4 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open link from WebUSB in the last used profile. This switches WebUSB notifications from using ProfileManager::GetActiveProfile() to ProfileManager::GetLastUsedProfileAllowedByPolicy(). This means that when a single Chrome instance has multiple profiles configured the one with a currently active window will be selected to open the new tab. Previously the default profile was always used. BUG=None TEST=Verified new tab is opened in the most recently used Chrome window and that new windows are still successfully created on Chrome OS in regular and guest mode. Committed: https://crrev.com/da2f47e15386469dba99bff3035a84d1720a9974 Cr-Commit-Position: refs/heads/master@{#431969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/usb/web_usb_detector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 1 month ago (2016-11-14 22:26:08 UTC) #3
juncai
LGTM.
4 years, 1 month ago (2016-11-14 22:41:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505433002/1
4 years, 1 month ago (2016-11-14 22:44:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:30:59 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:43:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da2f47e15386469dba99bff3035a84d1720a9974
Cr-Commit-Position: refs/heads/master@{#431969}

Powered by Google App Engine
This is Rietveld 408576698