Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2505413003:
Add check_build_deps step to gclient runhooks (Closed)
|
Created:
4 years, 1 month ago by Tom (Use chromium acct) Modified:
4 years, 1 month ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd check_build_deps step to gclient runhooks
This CL adds a build hook to ensure that any necessary build
dependencies are installed before proceeding with the
build. A failure would indicate install_build_deps.sh
needs to be rerun.
BUG=666937
R=dpranke@chromium.org
Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230
Cr-Commit-Position: refs/heads/master@{#433603}
Patch Set 1 #Patch Set 2 : Add python wrapper for check-build-deps #
Messages
Total messages: 29 (18 generated)
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Description was changed from ========== Add check_build_deps step to gclient runhooks ========== to ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
dpranke@ PTAL at PS2
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
lgtm
Description was changed from ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. ========== to ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org ==========
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@google.com
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479752844777210,
"parent_rev": "95bf867a653baf765bc7473d714b255cd1af0793", "commit_rev":
"d42753a957d9ad17999307b61587103e196bf5cb"}
Message was sent while issue was closed.
Description was changed from ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org ========== to ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org ========== to ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 Cr-Commit-Position: refs/heads/master@{#433603} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 Cr-Commit-Position: refs/heads/master@{#433603}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2521733002/ by anthonyvd@chromium.org. The reason for reverting is: This change breaks the following bot: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%2... This appears to be the intended behavior of the change, although the bots should probably not break when it lands to avoid a closed tree..
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2520923004/ by piman@chromium.org. The reason for reverting is: Breaks gclient runhooks https://build.chromium.org/p/chromium.linux/buildstatus?builder=Cast%20Androi....
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2515393002/ by mdjones@chromium.org. The reason for reverting is: Breaking builds on Cast Android (dbg), Android Cronet x86 Builder (dbg), etc.: Missing build dependencies. Try running 'build/install-build-deps.sh'.
Message was sent while issue was closed.
Description was changed from ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 Cr-Commit-Position: refs/heads/master@{#433603} ========== to ========== Add check_build_deps step to gclient runhooks This CL adds a build hook to ensure that any necessary build dependencies are installed before proceeding with the build. A failure would indicate install_build_deps.sh needs to be rerun. BUG=666937 R=dpranke@chromium.org Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 Cr-Commit-Position: refs/heads/master@{#433603} ==========
Message was sent while issue was closed.
Ooh! Revert race :). The tree breakage/closure was expected and intentionally approved by me. There were alternatives but I didn't think they were worth the effort. Now that we have good data around a set of broken builders, we'll get them fixed and hopefully subsequent attempts will be smoother. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
