Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html

Issue 2505413002: [DevTools] Prepare JavaScriptSourceFrame for multiple breakpoints per line (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
index 766e338e2c9d5ed4d9aba15e4fee140da91b9ce7..db298e070bf60ff12925adc7213048643cfb766b 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
@@ -5,21 +5,9 @@
<script src="../../../http/tests/inspector/live-edit-test.js"></script>
<script src="resources/edit-me-breakpoints.js"></script>
<script>
-function loadDynamicAnonymousScript()
-{
- function testFunction()
- {
- debugger;
- }
- var scriptElement = document.createElement("script");
- scriptElement.textContent = String(testFunction);
- docuemnt.head.appendChild(scriptElement);
-}
function test()
{
- var panel = UI.panels.sources;
-
function pathToFileName(path)
{
return path.substring(path.lastIndexOf("/") + 1).replace(/VM[\d]+/, "VMXX");
@@ -44,7 +32,7 @@ function test()
InspectorTest.addResult(" url: " + pathToFileName(url) + ", lineNumber: " + lineNumber + ", project type: " + project.type());
}
- breakpoints = breakpointManager.allBreakpoints();
+ breakpoints = breakpointManager._allBreakpoints();
InspectorTest.addResult(" Dumping breakpoints");
for (var i = 0; i < breakpoints.length; ++i) {
var breakpoint = breakpoints[i];
@@ -56,18 +44,6 @@ function test()
}
}
- function addBreakpointSniffer(lineNumber, disabled)
- {
- var prefix = this.main ? "" : "Original";
- InspectorTest.addResult(" " + prefix + "TextEditor.addBreakpoint(lineNumber = " + lineNumber + ", disabled = " + disabled + ")");
- }
-
- function removeBreakpointSniffer(lineNumber)
- {
- var prefix = this.main ? "" : "Original";
- InspectorTest.addResult(" " + prefix + "TextEditor.removeBreakpoint(lineNumber = " + lineNumber + ")");
- }
-
Bindings.breakpointManager._storage._breakpoints = {};
InspectorTest.runDebuggerTestSuite([
@@ -81,11 +57,7 @@ function test()
{
javaScriptSourceFrame = sourceFrame;
uiSourceCode = sourceFrame._uiSourceCode;
- javaScriptSourceFrame._textEditor.main = true;
-
- InspectorTest.addSniffer(javaScriptSourceFrame._textEditor.__proto__, "addBreakpoint", addBreakpointSniffer, true);
- InspectorTest.addSniffer(javaScriptSourceFrame._textEditor.__proto__, "removeBreakpoint", removeBreakpointSniffer, true);
-
+
InspectorTest.addResult("Setting breakpoint:");
InspectorTest.addSniffer(Bindings.BreakpointManager.TargetBreakpoint.prototype, "_didSetBreakpointInDebugger", breakpointResolved);
InspectorTest.setBreakpoint(sourceFrame, 2, "", true);

Powered by Google App Engine
This is Rietveld 408576698