third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html - Issue 2505413002: [DevTools] Prepare JavaScriptSourceFrame for multiple breakpoints per line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

Issue 2505413002: [DevTools] Prepare JavaScriptSourceFrame for multiple breakpoints per line (Closed)

Patch Set: added test for decorations, edit one is coming Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame-expected.txt ('K') | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html » ('j') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

index de3682e0aa1c8b288660030c09d7024127d92808..14e017ab870600bf2fbdc8de4f6b131d5e4a84c1 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html

@@ -113,7 +113,7 @@ function test()

function didShowScriptSource(sourceFrame)

{

- InspectorTest.addSniffer(sourceFrame, "_addBreakpointDecoration", breakpointAdded);

+ InspectorTest.waitJavaScriptSourceFrameBreakpoints(sourceFrame).then(breakpointAdded);

InspectorTest.setBreakpoint(sourceFrame, 2, "", true);

}

@@ -140,12 +140,12 @@ function test()

function didShowScriptSource(sourceFrame)

{

testSourceFrame = sourceFrame;

- InspectorTest.addSniffer(sourceFrame, "_addBreakpointDecoration", uiBreakpointAdded);

+ InspectorTest.waitJavaScriptSourceFrameBreakpoints(testSourceFrame).then(uiBreakpointAdded);

InspectorTest.setBreakpoint(sourceFrame, 3, "", true);

}

function uiBreakpointAdded() {

- InspectorTest.addSniffer(testSourceFrame, "_addBreakpointDecoration", breakpointAdded);

+ InspectorTest.waitJavaScriptSourceFrameBreakpoints(testSourceFrame).then(breakpointAdded);

}

function breakpointAdded()