Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html

Issue 2505413002: [DevTools] Prepare JavaScriptSourceFrame for multiple breakpoints per line (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
index 766e338e2c9d5ed4d9aba15e4fee140da91b9ce7..46e4b77c24d82bf7193a690075be72d01eb57699 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
@@ -56,16 +56,14 @@ function test()
}
}
- function addBreakpointSniffer(lineNumber, disabled)
+ function breakpointDecorationUpdatedSniffer(lineNumber, disabled, removed)
{
- var prefix = this.main ? "" : "Original";
- InspectorTest.addResult(" " + prefix + "TextEditor.addBreakpoint(lineNumber = " + lineNumber + ", disabled = " + disabled + ")");
- }
-
- function removeBreakpointSniffer(lineNumber)
- {
- var prefix = this.main ? "" : "Original";
- InspectorTest.addResult(" " + prefix + "TextEditor.removeBreakpoint(lineNumber = " + lineNumber + ")");
+ var prefix = this._textEditor.main ? "" : "Original";
+ if (!removed) {
+ InspectorTest.addResult(" " + prefix + "TextEditor.addBreakpoint(lineNumber = " + lineNumber + ", disabled = " + disabled + ")");
+ } else {
+ InspectorTest.addResult(" " + prefix + "TextEditor.removeBreakpoint(lineNumber = " + lineNumber + ")");
+ }
}
Bindings.breakpointManager._storage._breakpoints = {};
@@ -83,8 +81,7 @@ function test()
uiSourceCode = sourceFrame._uiSourceCode;
javaScriptSourceFrame._textEditor.main = true;
- InspectorTest.addSniffer(javaScriptSourceFrame._textEditor.__proto__, "addBreakpoint", addBreakpointSniffer, true);
- InspectorTest.addSniffer(javaScriptSourceFrame._textEditor.__proto__, "removeBreakpoint", removeBreakpointSniffer, true);
+ InspectorTest.addSniffer(javaScriptSourceFrame.__proto__, "_breakpointDecorationsUpdatedForTest", breakpointDecorationUpdatedSniffer, true);
InspectorTest.addResult("Setting breakpoint:");
InspectorTest.addSniffer(Bindings.BreakpointManager.TargetBreakpoint.prototype, "_didSetBreakpointInDebugger", breakpointResolved);

Powered by Google App Engine
This is Rietveld 408576698