Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2505413002: [DevTools] Prepare JavaScriptSourceFrame for multiple breakpoints per line (Closed)
Patch Set: addressed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 var lineBreakpoints = breakpoints[i]; 325 var lineBreakpoints = breakpoints[i];
326 var columnBreakpointArrays = lineBreakpoints ? lineBreakpoints.valuesArray () : []; 326 var columnBreakpointArrays = lineBreakpoints ? lineBreakpoints.valuesArray () : [];
327 result = result.concat.apply(result, columnBreakpointArrays); 327 result = result.concat.apply(result, columnBreakpointArrays);
328 } 328 }
329 return result; 329 return result;
330 } 330 }
331 331
332 /** 332 /**
333 * @return {!Array.<!Bindings.BreakpointManager.Breakpoint>} 333 * @return {!Array.<!Bindings.BreakpointManager.Breakpoint>}
334 */ 334 */
335 allBreakpoints() { 335 _allBreakpoints() {
336 var result = []; 336 var result = [];
337 var uiSourceCodes = this._breakpointsForUISourceCode.keysArray(); 337 var uiSourceCodes = this._breakpointsForUISourceCode.keysArray();
338 for (var i = 0; i < uiSourceCodes.length; ++i) 338 for (var i = 0; i < uiSourceCodes.length; ++i)
339 result = result.concat(this.breakpointsForUISourceCode(uiSourceCodes[i])); 339 result = result.concat(this.breakpointsForUISourceCode(uiSourceCodes[i]));
340 return result; 340 return result;
341 } 341 }
342 342
343 /** 343 /**
344 * @param {!Workspace.UISourceCode} uiSourceCode 344 * @param {!Workspace.UISourceCode} uiSourceCode
345 * @return {!Array.<!{breakpoint: !Bindings.BreakpointManager.Breakpoint, uiLo cation: !Workspace.UILocation}>} 345 * @return {!Array.<!{breakpoint: !Bindings.BreakpointManager.Breakpoint, uiLo cation: !Workspace.UILocation}>}
(...skipping 27 matching lines...) Expand all
373 var uiSourceCodes = this._breakpointsForUISourceCode.keysArray(); 373 var uiSourceCodes = this._breakpointsForUISourceCode.keysArray();
374 for (var i = 0; i < uiSourceCodes.length; ++i) 374 for (var i = 0; i < uiSourceCodes.length; ++i)
375 result = result.concat(this.breakpointLocationsForUISourceCode(uiSourceCod es[i])); 375 result = result.concat(this.breakpointLocationsForUISourceCode(uiSourceCod es[i]));
376 return result; 376 return result;
377 } 377 }
378 378
379 /** 379 /**
380 * @param {boolean} toggleState 380 * @param {boolean} toggleState
381 */ 381 */
382 toggleAllBreakpoints(toggleState) { 382 toggleAllBreakpoints(toggleState) {
383 var breakpoints = this.allBreakpoints(); 383 var breakpoints = this._allBreakpoints();
384 for (var i = 0; i < breakpoints.length; ++i) 384 for (var i = 0; i < breakpoints.length; ++i)
385 breakpoints[i].setEnabled(toggleState); 385 breakpoints[i].setEnabled(toggleState);
386 } 386 }
387 387
388 removeAllBreakpoints() { 388 removeAllBreakpoints() {
389 var breakpoints = this.allBreakpoints(); 389 var breakpoints = this._allBreakpoints();
390 for (var i = 0; i < breakpoints.length; ++i) 390 for (var i = 0; i < breakpoints.length; ++i)
391 breakpoints[i].remove(); 391 breakpoints[i].remove();
392 } 392 }
393 393
394 _projectRemoved(event) { 394 _projectRemoved(event) {
395 var project = /** @type {!Workspace.Project} */ (event.data); 395 var project = /** @type {!Workspace.Project} */ (event.data);
396 var uiSourceCodes = project.uiSourceCodes(); 396 var uiSourceCodes = project.uiSourceCodes();
397 for (var i = 0; i < uiSourceCodes.length; ++i) 397 for (var i = 0; i < uiSourceCodes.length; ++i)
398 this._removeUISourceCode(uiSourceCodes[i]); 398 this._removeUISourceCode(uiSourceCodes[i]);
399 } 399 }
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 this.sourceFileId = breakpoint._sourceFileId; 1093 this.sourceFileId = breakpoint._sourceFileId;
1094 this.lineNumber = breakpoint.lineNumber(); 1094 this.lineNumber = breakpoint.lineNumber();
1095 this.columnNumber = breakpoint.columnNumber(); 1095 this.columnNumber = breakpoint.columnNumber();
1096 this.condition = breakpoint.condition(); 1096 this.condition = breakpoint.condition();
1097 this.enabled = breakpoint.enabled(); 1097 this.enabled = breakpoint.enabled();
1098 } 1098 }
1099 }; 1099 };
1100 1100
1101 /** @type {!Bindings.BreakpointManager} */ 1101 /** @type {!Bindings.BreakpointManager} */
1102 Bindings.breakpointManager; 1102 Bindings.breakpointManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698