Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2505393003: Mojo EDK: Speculatively disable peer connection tests on Android (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo EDK: Speculatively disable peer connection tests on Android Lots of flake appeared in the mojo_system_unittests suite on Android bots after these tests were added. This speculatively disables those tests on Android, where the feature isn't used in production anyway. BUG=666356 TBR=sammc@chromium.org Committed: https://crrev.com/3bd8a572a0ab8ec0dd9df7195d4212ed86d1f6ae Cr-Commit-Position: refs/heads/master@{#432925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505393003/1
4 years, 1 month ago (2016-11-17 18:34:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 18:41:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3bd8a572a0ab8ec0dd9df7195d4212ed86d1f6ae Cr-Commit-Position: refs/heads/master@{#432925}
4 years, 1 month ago (2016-11-17 20:28:16 UTC) #10
Ken Rockot(use gerrit already)
4 years, 1 month ago (2016-11-18 15:34:42 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2504193005/ by rockot@chromium.org.

The reason for reverting is: Didn't fix the problem..

Powered by Google App Engine
This is Rietveld 408576698