Restrict sending GWS ID only to signed in users

chrome/browser/android/data_usage/external_data_use_observer_bridge.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/external_data_use_observer_bridge.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/android/context_utils.h"
 #include "base/android/jni_string.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/android/data_usage/data_use_tab_model.h"
 #include "chrome/browser/android/data_usage/external_data_use_observer.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "components/signin/core/browser/signin_manager.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 #include "jni/ExternalDataUseObserver_jni.h"
 
 using base::android::ConvertUTF8ToJavaString;
 
 namespace {
 
 // Name of the external data use observer synthetic field trial, enabled and
 // disabled groups.
@@ skipping 174 matching lines @@
     bool should_register) const {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!j_external_data_use_observer_.is_null());
 
   io_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&ExternalDataUseObserver::ShouldRegisterAsDataUseObserver,
                  external_data_use_observer_, should_register));
 
   variations::VariationID variation_id = GetGoogleVariationID();
-  if (variation_id != variations::EMPTY_ID) {
+  Profile* profile = ProfileManager::GetLastUsedProfile();

[tbansal1, 2016/11/18 00:05:25]

Is there a need to check if profile is incognito?

[Raj, 2016/12/12 18:51:11]

Done. ExternalDataUseObserver and other objects should not get created for
incognito profiles.
But still doing the check.

+  DCHECK(profile);
+  const SigninManager* signin_manager =
+      SigninManagerFactory::GetForProfileIfExists(profile);
+  if (variation_id != variations::EMPTY_ID && signin_manager &&
+      signin_manager->IsAuthenticated()) {
     // Set variation id for the enabled group if |should_register| is true.
     // Otherwise clear the variation id for the enabled group by setting to
     // EMPTY_ID.
     variations::AssociateGoogleVariationID(
         variations::GOOGLE_WEB_PROPERTIES, kSyntheticFieldTrial,
         kSyntheticFieldTrialEnabledGroup,
         should_register ? variation_id : variations::EMPTY_ID);
     ChromeMetricsServiceAccessor::RegisterSyntheticFieldTrial(
         kSyntheticFieldTrial, should_register
                                   ? kSyntheticFieldTrialEnabledGroup
                                   : kSyntheticFieldTrialDisabledGroup);
   }
 }
 
 bool RegisterExternalDataUseObserver(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 
 }  // namespace chrome