Issue 25053002: Fix threading problems in test-api when running on simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25053002: Fix threading problems in test-api when running on simulator (Closed)

Created:
7 years, 2 months ago by yurys

Modified:
7 years, 2 months ago

Reviewers:
Benedikt Meurer, Michael Achenbach

CC:
v8-dev, alph, loislo

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix threading problems in test-api when running on simulator Sampler can retrieve current simulator for profiled isolate from its ThreadLocalTop without calls to Isolate::FindPerThreadDataForThread which sometimes leads to acquring same mutex second time. BUG=v8:2874 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17047

Patch Set 1 #

Patch Set 2 : Removed simulator() getter from isolate #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -25 lines)			Patch
M	src/isolate.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/sampler.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 2 months ago (2013-10-01 13:55:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17047 (presubmit successful).

Expand Messages | Collapse Messages