Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2505283002: Revert of Initial implementation of V8 Top 25 Runtime Stats benchmark (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/v8_top_25.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index eafeeb93f877b47317964de82eff4266bdda7a3e..167c07a7603012ebdcb1d490395df86f471e3348 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -228,61 +228,3 @@
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
-
-
-class _Top25RuntimeStats(perf_benchmark.PerfBenchmark):
- options = {'pageset_repeat': 1}
-
- def CreateTimelineBasedMeasurementOptions(self):
- # TODO(fmeawad): most of the cat_filter information is extracted from
- # page_cycler_v2 TimelineBasedMeasurementOptionsForLoadingMetric because
- # used by the loadingMetric because the runtimeStatsMetric uses the
- # interactive time calculated internally by the loadingMetric.
- # It is better to share the code so that we can keep them in sync.
- cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
-
- # "blink.console" is used for marking ranges in
- # cache_temperature.MarkTelemetryInternal.
- cat_filter.AddIncludedCategory('blink.console')
-
- # "navigation" and "blink.user_timing" are needed to capture core
- # navigation events.
- cat_filter.AddIncludedCategory('navigation')
- cat_filter.AddIncludedCategory('blink.user_timing')
-
- # "loading" is needed for first-meaningful-paint computation.
- cat_filter.AddIncludedCategory('loading')
-
- # "toplevel" category is used to capture TaskQueueManager events
- # necessary to compute time-to-interactive.
- cat_filter.AddIncludedCategory('toplevel')
-
- # V8 needed categories
- cat_filter.AddIncludedCategory('v8')
- cat_filter.AddDisabledByDefault('disabled-by-default-v8.runtime_stats')
-
- tbm_options = timeline_based_measurement.Options(
- overhead_level=cat_filter)
- tbm_options.SetTimelineBasedMetrics(['runtimeStatsMetric'])
- return tbm_options
-
- @classmethod
- def ShouldDisable(cls, possible_browser):
- if possible_browser.browser_type == 'reference':
- return True
- return False
-
-
-class V8Top25RuntimeStats(_Top25RuntimeStats):
- """Runtime Stats benchmark for a 25 top V8 web pages.
-
- Designed to represent a mix between top websites and a set of pages that
- have unique V8 characteristics.
- """
-
- @classmethod
- def Name(cls):
- return 'v8.runtime_stats.top_25'
-
- def CreateStorySet(self, options):
- return page_sets.V8Top25StorySet()
« no previous file with comments | « no previous file | tools/perf/page_sets/data/v8_top_25.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698