Mojo EDK: Never notify own watchers within public API calls

Mojo EDK: Never notify own watchers within public API calls

Watcher notification requires a lock to be held, and arbitrary user
code may be invoked while within that stack. As such we should never
wake up a message pipe's own watcher from within a public API call
on that pipe's handle.

This removes such notifications from ReadMessage and WriteMessage.
The notifications are entirely redundant anyway, since they will have
already been triggered by OnPortStatusChanged when the underlying port
was closed.

BUG=665996
R=yzshen@chromium.org

Committed: https://crrev.com/74279d49e257153aaac8b9362473c2a5d789dfd8
Cr-Commit-Position: refs/heads/master@{#432739}

[Ken Rockot(use gerrit already), 2016-11-17 00:54:29]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-11-17 00:54:51]

Description was changed from

==========
Mojo EDK: Never notify watchers within public API calls

Watcher notification requires a lock to be held, and arbitrary user
code may be invoked while within that stack. As such we should never
wake up a message pipe's own watcher from within a public API call
on that pipe's handle.

This removes such notifications from ReadMessage and WriteMessage.
The notifications are entirely redundant anyway, since they will have
already been triggered by OnPortStatusChanged when the underlying port
was closed.

BUG=665996
R=yzshen@chromium.org
==========

to

==========
Mojo EDK: Never notify own watchers within public API calls

Watcher notification requires a lock to be held, and arbitrary user
code may be invoked while within that stack. As such we should never
wake up a message pipe's own watcher from within a public API call
on that pipe's handle.

This removes such notifications from ReadMessage and WriteMessage.
The notifications are entirely redundant anyway, since they will have
already been triggered by OnPortStatusChanged when the underlying port
was closed.

BUG=665996
R=yzshen@chromium.org
==========

[commit-bot: I haz the power, 2016-11-17 00:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-11-17 00:56:58]

lgtm

[Ken Rockot(use gerrit already), 2016-11-17 01:43:01]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-17 01:43:05]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:59:00]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[Ken Rockot(use gerrit already), 2016-11-17 03:13:27]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:15:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:23:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 04:26:49]

Description was changed from

==========
Mojo EDK: Never notify own watchers within public API calls

Watcher notification requires a lock to be held, and arbitrary user
code may be invoked while within that stack. As such we should never
wake up a message pipe's own watcher from within a public API call
on that pipe's handle.

This removes such notifications from ReadMessage and WriteMessage.
The notifications are entirely redundant anyway, since they will have
already been triggered by OnPortStatusChanged when the underlying port
was closed.

BUG=665996
R=yzshen@chromium.org
==========

to

==========
Mojo EDK: Never notify own watchers within public API calls

Watcher notification requires a lock to be held, and arbitrary user
code may be invoked while within that stack. As such we should never
wake up a message pipe's own watcher from within a public API call
on that pipe's handle.

This removes such notifications from ReadMessage and WriteMessage.
The notifications are entirely redundant anyway, since they will have
already been triggered by OnPortStatusChanged when the underlying port
was closed.

BUG=665996
R=yzshen@chromium.org

Committed: https://crrev.com/74279d49e257153aaac8b9362473c2a5d789dfd8
Cr-Commit-Position: refs/heads/master@{#432739}
==========

[commit-bot: I haz the power, 2016-11-17 04:26:50]

Patchset 1 (id:??) landed as
https://crrev.com/74279d49e257153aaac8b9362473c2a5d789dfd8
Cr-Commit-Position: refs/heads/master@{#432739}