Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 250523004: Added remote 'git' branch awareness to 'gclient' (Closed)

Created:
6 years, 8 months ago by Dan Jacques
Modified:
5 years, 11 months ago
Reviewers:
dnj, agable, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Added remote 'git' branch awareness to 'gclient'; this is needed to check out specific Gerrit patch sets, as those aren't included with the standard 'master' pull. This is done by adding a common revision parsing function and adding additional 'fetch' commands at appropriate points. Added test for revision parsing and related functionality. BUG=278188 TEST=local,unittests R=agable@chromium.org, maruel@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to fetch on branch sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -29 lines) Patch
M gclient_scm.py View 1 7 chunks +105 lines, -26 lines 0 comments Download
M testing_support/fake_repos.py View 4 chunks +32 lines, -2 lines 0 comments Download
M tests/gclient_scm_test.py View 1 chunk +74 lines, -0 lines 0 comments Download
M tests/gclient_smoketest.py View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dnj (Google)
Hey, could you please review and/or weigh in on some proposed 'gclient' changes? The motivation ...
6 years, 8 months ago (2014-04-24 19:30:44 UTC) #1
M-A Ruel
I just saw this CL, is it still applicable?
5 years, 11 months ago (2015-01-15 18:53:08 UTC) #2
dnj
5 years, 11 months ago (2015-01-15 18:55:17 UTC) #3
Probably not. I'll close it, as it'll almost certainly need to be recreated even
if used.

Powered by Google App Engine
This is Rietveld 408576698