Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 250523002: chrome.hid: rebase wrt last changes (Closed)

Created:
6 years, 8 months ago by jracle (use Gerrit)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

chrome.hid: rebase wrt last changes BUG=359560 TBR=rockot@chromium.org TBR=scheib@chromium.org chrome.hid : enrich device info with Top-Level collections usages - works on Windows and Mac. - change ongoing for Chrome OS / Linux -> will be part of separate commit BUG=359560 TBR=rockot@chromium.org TBR=scheib@chromium.org

Patch Set 1 : enrich device info with hid usages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1548 lines, -72 lines) Patch
M chrome/browser/extensions/api/hid/hid_device_manager.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/hid.idl View 1 chunk +13 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M device/hid/hid_connection_linux.h View 2 chunks +1 line, -4 lines 0 comments Download
M device/hid/hid_connection_linux.cc View 2 chunks +1 line, -50 lines 0 comments Download
M device/hid/hid_device_info.h View 2 chunks +3 lines, -5 lines 0 comments Download
M device/hid/hid_device_info.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A device/hid/hid_report_descriptor.h View 1 chunk +800 lines, -0 lines 0 comments Download
A device/hid/hid_report_descriptor.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A device/hid/hid_report_descriptor_unittest.cc View 1 chunk +256 lines, -0 lines 0 comments Download
M device/hid/hid_service_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/hid/hid_service_linux.cc View 6 chunks +94 lines, -5 lines 0 comments Download
M device/hid/hid_service_mac.cc View 1 chunk +18 lines, -4 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A device/hid/hid_usage_and_page.h View 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jracle (use Gerrit)
Created after rebasing https://codereview.chromium.org/225513005/
6 years, 8 months ago (2014-04-24 08:20:13 UTC) #1
Ken Rockot(use gerrit already)
On 2014/04/24 08:20:13, jracle wrote: > Created after rebasing https://codereview.chromium.org/225513005/ Please don't create a new ...
6 years, 8 months ago (2014-04-24 14:55:49 UTC) #2
jracle (use Gerrit)
6 years, 8 months ago (2014-04-24 15:02:12 UTC) #3
On 2014/04/24 14:55:49, Ken Rockot wrote:
> On 2014/04/24 08:20:13, jracle wrote:
> > Created after rebasing https://codereview.chromium.org/225513005/
> 
> Please don't create a new CL for the rebase.
> 
> In the local branch from which you uploaded this rebase, run:
> 
> git cl issue 225513005
> git cl upload
> 
> It might present a warning which you can ignore. This will push the rebase up
as
> a new patchset on your previous CL.

Oh ok, sorry, I missed the command! Thanks

Powered by Google App Engine
This is Rietveld 408576698