Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2505223002:
Roll WebGL 6b0934a..f1cbc14 (Closed)
|
Created:
4 years, 1 month ago by Zhenyao Mo Modified:
4 years, 1 month ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, Geoff Lang Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll WebGL 6b0934a..f1cbc14
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934a..f1cbc14
BUG=
TEST=bots
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/62fd8f8b1160ce61fa3b031fffa8626609ccdd29
Cr-Commit-Position: refs/heads/master@{#432722}
Patch Set 1 #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
zmo@chromium.org changed reviewers: + kbr@chromium.org
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was unchecked by zmo@chromium.org
On 2016/11/17 01:19:17, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Landing with NOTRY. android_cronet failure is caused by goma outage and it has nothing to do with webgl
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/62fd8f8b1160ce61fa3b031fffa8626609ccdd29 Cr-Commit-Position: refs/heads/master@{#432722} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/62fd8f8b1160ce61fa3b031fffa8626609ccdd29 Cr-Commit-Position: refs/heads/master@{#432722}
Message was sent while issue was closed.
I think that since this roll, we're seeing failures in WebglConformance_conformance2_textures_misc_tex_mipmap_levels and WebglConformance_deqp_functional_gles3_shadertexturefunction_texturesize on Linux Release (New Intel). They first fail here: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... and continue here https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...
Message was sent while issue was closed.
On 2016/11/17 14:45:32, Geoff Lang wrote: > I think that since this roll, we're seeing failures in > WebglConformance_conformance2_textures_misc_tex_mipmap_levels and > WebglConformance_deqp_functional_gles3_shadertexturefunction_texturesize on > Linux Release (New Intel). > > They first fail here: > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > and continue here > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... It can't be as there is only a minor fix in this roll. Flakiness has to come from somewhere else.
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/62fd8f8b1160ce61fa3b031fffa8626609ccdd29 Cr-Commit-Position: refs/heads/master@{#432722} ========== to ========== Roll WebGL 6b0934a..f1cbc14 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6b0934... BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/62fd8f8b1160ce61fa3b031fffa8626609ccdd29 Cr-Commit-Position: refs/heads/master@{#432722} ==========
Message was sent while issue was closed.
On 2016/11/17 14:53:33, Zhenyao Mo wrote: > On 2016/11/17 14:45:32, Geoff Lang wrote: > > I think that since this roll, we're seeing failures in > > WebglConformance_conformance2_textures_misc_tex_mipmap_levels and > > WebglConformance_deqp_functional_gles3_shadertexturefunction_texturesize on > > Linux Release (New Intel). > > > > They first fail here: > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > > and continue here > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... > > It can't be as there is only a minor fix in this roll. Flakiness has to come > from somewhere else. Geoff: please file a bug about these failures. Since they are happening only on Linux Intel, they look like possible driver bugs to me. https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N... contains https://chromium.googlesource.com/chromium/src/+/5e6600b56cad269e4a8640c33084... , which is a longstanding issue only just discovered, and which seems to be working well on all the other platforms. |
