[net/auth] Reset AuthChallengeInfo before picking a new HttpAuthHandler.

net/http/http_auth_controller.cc

Index: net/http/http_auth_controller.cc
diff --git a/net/http/http_auth_controller.cc b/net/http/http_auth_controller.cc
index 01245a9b8c7f9af7f94e306302740518ef6450c3..39361b44ed5633d100a4b5fb0998cd7c9f934d66 100644
--- a/net/http/http_auth_controller.cc
+++ b/net/http/http_auth_controller.cc
@@ -277,6 +277,7 @@ int HttpAuthController::HandleAuthChallenge(
   }
 
   identity_.invalid = true;
+  auth_info_ = nullptr;

[mmenke, 2016/11/17 16:07:19]

Can this be put at the start of this method?  I don't think anything needs to
know about the previous auth challenge.

[mmenke, 2016/11/17 16:07:19]

Please add a comment along the lines:  "Clear information about the previous
auth challenge."  As-is, it's non-obvious that this is the old challenge, and
not the new one.

[asanka, 2016/11/17 18:01:25]

I moved it all the way up to ResetAuth and commented there. Reasoning for this
is in the CL description.

 
   bool can_send_auth = (target_ != HttpAuth::AUTH_SERVER ||
                         !do_not_send_server_auth);
@@ -326,8 +327,6 @@ int HttpAuthController::HandleAuthChallenge(
         // Pass the challenge information back to the client.
         PopulateAuthChallenge();
       }
-    } else {
-      auth_info_ = NULL;
     }
 
     // If we get here and we don't have a handler_, that's because we