Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2505183002: Have tests verify clientX/Y and pageX/Y properties in drag-and-drop DOM events. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, tfarina, dcheng, site-isolation-reviews_chromium.org, paulmeyer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have tests verify clientX/Y and pageX/Y properties in drag-and-drop DOM events. BUG=647249 Committed: https://crrev.com/3fe58d959352eb364feda915a7bec8528d7b42a2 Cr-Commit-Position: refs/heads/master@{#432699}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc View 6 chunks +18 lines, -2 lines 1 comment Download
M chrome/test/data/drag_and_drop/event_monitoring.js View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2507223003 Patch 1

Messages

Total messages: 11 (6 generated)
Łukasz Anforowicz
Nick, can you take a look please? https://codereview.chromium.org/2505183002/diff/1/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc File chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc (right): https://codereview.chromium.org/2505183002/diff/1/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc#newcode153 chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc:153: *out_event_root_location = ...
4 years, 1 month ago (2016-11-16 23:02:38 UTC) #4
ncarter (slow)
lgtm
4 years, 1 month ago (2016-11-16 23:04:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505183002/1
4 years, 1 month ago (2016-11-16 23:10:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 01:58:02 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:07:18 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fe58d959352eb364feda915a7bec8528d7b42a2
Cr-Commit-Position: refs/heads/master@{#432699}

Powered by Google App Engine
This is Rietveld 408576698