Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2505163002: Deflake images/cross-fade-invalidation.html (Closed)

Created:
4 years, 1 month ago by Stephen Chennney
Modified:
4 years, 1 month ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake images/cross-fade-invalidation.html The test was using a 200ms timeout in order to allow the SVG image to animate (which should only take 10ms). I suspect that load time was impacting things, so try moving the test logic to window.onload and reduce the timeout to 100ms. It may be that the SVG is not starting at all in some cases, which would be a more serious issue. TBR=fmalita@chromium.org BUG=665776 Committed: https://crrev.com/5beba54f865425e7e25f598505d72315afd9ca15 Cr-Commit-Position: refs/heads/master@{#433201}

Patch Set 1 #

Patch Set 2 : Try again to fix it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/images/cross-fade-invalidation.html View 1 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505163002/20001
4 years, 1 month ago (2016-11-17 22:09:29 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/338102)
4 years, 1 month ago (2016-11-18 00:06:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505163002/20001
4 years, 1 month ago (2016-11-18 14:25:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 15:33:17 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 15:35:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5beba54f865425e7e25f598505d72315afd9ca15
Cr-Commit-Position: refs/heads/master@{#433201}

Powered by Google App Engine
This is Rietveld 408576698