Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4365)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2505153002: Add support for scout to 'ext' param when creating SafeBrowsing ping URLs. (Closed)
Patch Set: Go back to IsExtendedReportingEnabled where level doesn't matter Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index cb88295cb26a6df5e174b7d5086223cbe140c748..95d9fd63e9dad541222de6ee589ed4bb989fa0b9 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -309,8 +309,9 @@ void SafeBrowsingUIManager::DisplayBlockingPage(
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
- hit_report.is_extended_reporting =
- profile && IsExtendedReportingEnabled(*profile->GetPrefs());
+ hit_report.extended_reporting_level =
+ profile ? GetExtendedReportingLevel(*profile->GetPrefs())
+ : SBER_LEVEL_OFF;
hit_report.is_metrics_reporting_active =
ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled();
@@ -336,7 +337,7 @@ void SafeBrowsingUIManager::MaybeReportSafeBrowsingHit(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Send report if user opted-in extended reporting.
- if (hit_report.is_extended_reporting) {
+ if (hit_report.extended_reporting_level != SBER_LEVEL_OFF) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&SafeBrowsingUIManager::ReportSafeBrowsingHitOnIOThread,
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc ('k') | components/safe_browsing_db/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698