Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2505133004: Remove the GN cookbook document. (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the GN cookbook document. This document was for listing equivalents between GYP and GN which are no longer relevant. Many of the items our out-of-date already, and it is not being updated further. I have already removed the references to this document from the Google Sites pages. Committed: https://crrev.com/6afdb84319431eb94809a5f2ef9f33960dd2dea6 Cr-Commit-Position: refs/heads/master@{#432897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -682 lines) Patch
M tools/gn/README.md View 1 chunk +0 lines, -1 line 0 comments Download
D tools/gn/docs/cookbook.md View 1 chunk +0 lines, -681 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
brettw
4 years, 1 month ago (2016-11-17 14:50:42 UTC) #2
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-17 16:43:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505133004/1
4 years, 1 month ago (2016-11-17 16:52:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:58:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 17:03:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6afdb84319431eb94809a5f2ef9f33960dd2dea6
Cr-Commit-Position: refs/heads/master@{#432897}

Powered by Google App Engine
This is Rietveld 408576698