Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2505033002: [System Health] Change from integer division to float division for News Stories (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
4 years, 1 month ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[System Health] Change from integer division to float division for News Stories A CL Yesterday changed the waiting pattern on news sites to do half before the scroll and half after. It is using int math instead of float math so it is waiting longer than it should. BUG=665220 Committed: https://crrev.com/fbdd4cf5f8069eb223fc72e6298a97854abd0374 Cr-Commit-Position: refs/heads/master@{#432551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rnephew (Reviews Here)
Thanks for finding this bug Juan!
4 years, 1 month ago (2016-11-16 15:20:11 UTC) #2
nednguyen
lgtm
4 years, 1 month ago (2016-11-16 15:20:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505033002/1
4 years, 1 month ago (2016-11-16 15:21:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 18:04:02 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 18:20:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbdd4cf5f8069eb223fc72e6298a97854abd0374
Cr-Commit-Position: refs/heads/master@{#432551}

Powered by Google App Engine
This is Rietveld 408576698