Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2505023004: Add assertions to ensure that only one instance of RemoteTestServer is (Closed)

Created:
4 years, 1 month ago by eroman
Modified:
4 years, 1 month ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add assertions to ensure that only one instance of RemoteTestServer is used at a time. This applies to Android, where RemoteTestServer only supports one test server at a time. (Creating others while one is already alive will lead to failures). BUG=665686 Committed: https://crrev.com/07dcb5fae952fa8e3343ed0db2d95b28edd416b5 Cr-Commit-Position: refs/heads/master@{#432756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M net/test/spawned_test_server/remote_test_server.cc View 4 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
eroman
4 years, 1 month ago (2016-11-17 02:44:47 UTC) #3
mattm
lgtm
4 years, 1 month ago (2016-11-17 02:48:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505023004/1
4 years, 1 month ago (2016-11-17 02:54:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 05:11:28 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 05:15:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07dcb5fae952fa8e3343ed0db2d95b28edd416b5
Cr-Commit-Position: refs/heads/master@{#432756}

Powered by Google App Engine
This is Rietveld 408576698