Issue 2505001: Fix more type issues from the npapi.h tranisition to *_t types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2505001: Fix more type issues from the npapi.h tranisition to *_t types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 12 months ago by stuartmorgan

Modified:
4 years ago

Reviewers:
jam

CC:
chromium-reviews, Aaron Boodman, stuartmorgan, pam+watch_chromium.org, Erik does not do reviews, darin-cc_chromium.org

Visibility:
Public.

Description

Fix more type issues from the npapi.h tranisition to *_t types Fixes the remaining not _t types in our plugin code Removes the extra typedefs added to our copy of npapi.h Adds headers to plugin code where necessary due to implicit dependencies on standard headers via basictypes.h BUG=42645 TEST=Everything still compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48952

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -36 lines)			Patch
M	third_party/npapi/bindings/npapi.h	View	1 2 3	1 chunk	+0 lines, -19 lines	0 comments	Download
M	third_party/npapi/bindings/npapi_extensions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/default_plugin/plugin_main.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	webkit/default_plugin/plugin_main.cc	View	1	10 chunks	+10 lines, -10 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/PluginObject.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/TestObject.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/main.cpp	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

4 years, 12 months ago (2010-06-04 18:15:22 UTC) #3

Unfortunately there's still a NaCl problem and something weird going on with
Linux, so I had to back off slightly, and I'll remove the last of the headers in
another patch.

No need to re-review, since the new version is just a subset of the original.

Expand Messages | Collapse Messages

Issue 2505001: Fix more type issues from the npapi.h tranisition to *_t types (Closed)

Description

Patch Set 1 #

Patch Set 2 : Whitespace fix #

Patch Set 3 : Rebase #

Patch Set 4 : scaled back #

Messages