Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 25050002: MIPS: Improve integer multiplication. (Closed)

Created:
7 years, 2 months ago by kilvadyb
Modified:
7 years, 2 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Improve integer multiplication. Port r16576 (8ce78a4) TEST=test/mjsunit/lithium/MulI.js BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -49 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 5 chunks +33 lines, -33 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +31 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
7 years, 2 months ago (2013-09-27 14:01:40 UTC) #1
Paul Lind
LGTM, but please fix the nits. https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1456 src/mips/lithium-codegen-mips.cc:1456: // Correct the ...
7 years, 2 months ago (2013-09-27 14:51:45 UTC) #2
kilvadyb
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1456 src/mips/lithium-codegen-mips.cc:1456: // Correct the sign of the result is the ...
7 years, 2 months ago (2013-09-27 15:54:06 UTC) #3
Paul Lind
7 years, 2 months ago (2013-09-27 16:23:59 UTC) #4
Committed as r16997.

Powered by Google App Engine
This is Rietveld 408576698