Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2504993002: [heap] Minor MC: Add evacuation phase (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Minor MC: Add evacuation phase - Reuse major MC evacuation infrastructure. - Add another path for refilling from old space when the sweeper is not running, effectively reusing more memory and keeping the old->new set more compact. BUG=chromium:651354

Patch Set 1 #

Patch Set 2 : Fix verification #

Patch Set 3 : Update #

Patch Set 4 : Rebase #

Patch Set 5 : Update #

Patch Set 6 : Fix global handles #

Patch Set 7 : Fix global handles #

Patch Set 8 : Fix global handles #

Patch Set 9 : Working in chrome #

Patch Set 10 : Reuse memory in old space #

Patch Set 11 : Rebase #

Patch Set 12 : Update #

Patch Set 13 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -41 lines) Patch
M src/heap/gc-tracer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 6 7 8 9 10 11 12 16 chunks +104 lines, -34 lines 1 comment Download
M src/heap/spaces.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +13 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +55 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
PTAL This seems to be on par with the scavenger on infinite_scroll_tbmv2. We already allocate ...
4 years, 1 month ago (2016-11-18 13:33:35 UTC) #8
Michael Lippautz
Ulan just mentioned that we need to sweep the pages that were moved because the ...
4 years, 1 month ago (2016-11-18 13:54:20 UTC) #9
Michael Lippautz
Brain dump: We could also do lazy sweeping (indicated by a page flag) by keeping ...
4 years, 1 month ago (2016-11-18 18:03:55 UTC) #10
Hannes Payer (out of office)
4 years ago (2016-11-23 11:25:37 UTC) #11
https://codereview.chromium.org/2504993002/diff/230001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2504993002/diff/230001/src/heap/mark-compact....
src/heap/mark-compact.cc:311:
EvacuateNewSpaceAndCandidates<MarkCompactMode::YOUNG_GENERATION>();
How about restructuring EvacuateNewSpaceAndCandidates such that we can only call
EvacuateNewSpace here?

Powered by Google App Engine
This is Rietveld 408576698