Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 2504973002: Remove invalid check (Closed)
Patch Set: Addressed comments + rebas Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 67c5019fed46c095e8be287eeb014e22f6758626..c6f3fe75fdf7b0987db640db2a661eaefd849a13 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -484,7 +484,14 @@ void AppWindow::SetOnFirstCommitCallback(const base::Closure& callback) {
}
void AppWindow::OnReadyToCommitFirstNavigation() {
- CHECK(content::IsBrowserSideNavigationEnabled());
+ if (!content::IsBrowserSideNavigationEnabled())
+ return;
+
+ // PlzNavigate: execute renderer-side setup now that there is a renderer
+ // process assigned to the navigation. In the current architecture, this would
Devlin 2016/11/17 15:51:19 optional nit: phrasing like "current architecture"
clamy 2016/11/21 16:05:09 Done.
+ // happen before the navigation starts, but PlzNavigate must wait until this
+ // point in time in the navigation.
+
WindowEventsReady();
if (on_first_commit_callback_.is_null())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698