Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h

Issue 2504963004: Record time to first data reduction proxy request (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
index 61e68265a057436fa9a19f64f3cd73648766e7c3..aae5abee0fb9631da282f2963b7af994d2943315 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
@@ -8,11 +8,17 @@
#include <string>
#include "base/macros.h"
+#include "base/threading/thread_checker.h"
+#include "net/base/network_change_notifier.h"
#include "net/base/proxy_delegate.h"
#include "net/proxy/proxy_retry_info.h"
#include "net/proxy/proxy_server.h"
#include "url/gurl.h"
+namespace base {
+class TickClock;
+}
+
namespace net {
class HostPortPair;
class HttpRequestHeaders;
@@ -30,19 +36,23 @@ class DataReductionProxyConfig;
class DataReductionProxyConfigurator;
class DataReductionProxyEventCreator;
-class DataReductionProxyDelegate : public net::ProxyDelegate {
+class DataReductionProxyDelegate
+ : public net::ProxyDelegate,
+ public net::NetworkChangeNotifier::IPAddressObserver {
public:
// ProxyDelegate instance is owned by io_thread. |auth_handler| and |config|
// outlives this class instance.
- explicit DataReductionProxyDelegate(
- DataReductionProxyConfig* config,
- const DataReductionProxyConfigurator* configurator,
- DataReductionProxyEventCreator* event_creator,
- DataReductionProxyBypassStats* bypass_stats,
- net::NetLog* net_log);
+ DataReductionProxyDelegate(DataReductionProxyConfig* config,
+ const DataReductionProxyConfigurator* configurator,
+ DataReductionProxyEventCreator* event_creator,
+ DataReductionProxyBypassStats* bypass_stats,
+ net::NetLog* net_log);
~DataReductionProxyDelegate() override;
+ // Performs initialization on the IO thread.
+ void InitializeOnIOThread();
+
// net::ProxyDelegate implementation:
void OnResolveProxy(const GURL& url,
const std::string& method,
@@ -60,6 +70,8 @@ class DataReductionProxyDelegate : public net::ProxyDelegate {
const net::HostPortPair& proxy_server,
const net::HttpResponseHeaders& response_headers) override;
+ void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock);
+
protected:
// Protected so that these methods are accessible for testing.
// net::ProxyDelegate implementation:
@@ -102,6 +114,9 @@ class DataReductionProxyDelegate : public net::ProxyDelegate {
void RecordGetDefaultAlternativeProxy(
DefaultAlternativeProxyStatus status) const;
+ // NetworkChangeNotifier::IPAddressObserver:
+ void OnIPAddressChanged() override;
+
const DataReductionProxyConfig* config_;
const DataReductionProxyConfigurator* configurator_;
DataReductionProxyEventCreator* event_creator_;
@@ -110,8 +125,22 @@ class DataReductionProxyDelegate : public net::ProxyDelegate {
// True if the use of alternate proxies is disabled.
bool alternative_proxies_broken_;
+ // Tick clock used for obtaining the current time.
+ std::unique_ptr<base::TickClock> tick_clock_;
+
+ // True if the metrics related to the first request whose resolved proxy was a
+ // data saver proxy has been recorded. |first_data_saver_request_recorded_| is
+ // reset to false on IP address change events.
+ bool first_data_saver_request_recorded_;
+
+ // Set to the time when last IP address change event was received, or the time
+ // of initialization of |this|, whichever is later.
+ base::TimeTicks last_network_change_time_;
+
net::NetLog* net_log_;
+ base::ThreadChecker thread_checker_;
+
DISALLOW_COPY_AND_ASSIGN(DataReductionProxyDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698