Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2504963003: Replace CroppingWindowCapturer::Create with CroppingWindowCapturer::CreateCapturer (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CroppingWindowCapturer::Create with CroppingWindowCapturer::CreateCapturer This is a trivial change to use CreateCapturer, which returns std::unique_ptr, to replace CroppingWindowCapturer::Create, which returns raw pointer. After this change, CroppingWindowCapturer::Create can be removed. BUG=webrtc:6513 Committed: https://crrev.com/005f42128c7645bbbeeb07e1ee59b86ce03ecc6c Cr-Commit-Position: refs/heads/master@{#433095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Hzj_jie
4 years, 1 month ago (2016-11-17 03:56:34 UTC) #7
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-18 00:51:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504963003/1
4 years, 1 month ago (2016-11-18 00:52:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 04:18:43 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:21:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/005f42128c7645bbbeeb07e1ee59b86ce03ecc6c
Cr-Commit-Position: refs/heads/master@{#433095}

Powered by Google App Engine
This is Rietveld 408576698