Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2504943003: [v8] Mark layout test for rebase after enabling Ignition. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Mark layout test for rebase after enabling Ignition. Enabling Ignition on a subset of language features requires a rebaseline of two Blink layout tests. The corresponding V8 roll has made it into Chromium two weeks ago and is sticking since then. R=rmcilroy@chromium.org BUG=chromium:657831 Committed: https://crrev.com/dee5e54faa37c4a02b21e1d0cfb5defb184f4d75 Cr-Commit-Position: refs/heads/master@{#432828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rmcilroy
lgtm
4 years, 1 month ago (2016-11-16 20:26:45 UTC) #5
Michael Starzinger
4 years, 1 month ago (2016-11-17 09:16:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504943003/1
4 years, 1 month ago (2016-11-17 09:25:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 09:30:00 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 09:32:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dee5e54faa37c4a02b21e1d0cfb5defb184f4d75
Cr-Commit-Position: refs/heads/master@{#432828}

Powered by Google App Engine
This is Rietveld 408576698