Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2504943002: Remove the "one at a time" restriction from the browsingData API (Closed)

Created:
4 years, 1 month ago by msramek
Modified:
4 years ago
Reviewers:
Mike West
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the "one at a time" restriction from the browsingData API As of https://codereview.chromium.org/2175703002, BrowsingDataRemover supports task exclusion and this is no longer necessary. BUG=630327 Committed: https://crrev.com/08165e64189a0c081f340b1819ab2e954d5266a1 Cr-Commit-Position: refs/heads/master@{#434177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
msramek
Hey Mike! Can you please have a look? I mentioned this change when we were ...
4 years, 1 month ago (2016-11-21 20:21:58 UTC) #6
Mike West
Hooray for removing code that we don't need anymore! LGTM.
4 years ago (2016-11-23 13:06:40 UTC) #7
msramek
Thanks!
4 years ago (2016-11-23 13:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504943002/1
4 years ago (2016-11-23 13:21:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/267751)
4 years ago (2016-11-23 14:03:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504943002/1
4 years ago (2016-11-23 14:12:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/320820)
4 years ago (2016-11-23 14:57:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504943002/1
4 years ago (2016-11-23 15:42:29 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 16:14:06 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-23 16:15:42 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08165e64189a0c081f340b1819ab2e954d5266a1
Cr-Commit-Position: refs/heads/master@{#434177}

Powered by Google App Engine
This is Rietveld 408576698