Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2504933002: [counters] Properly rename PreParse timers (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Properly rename PreParse timers BUG= Committed: https://crrev.com/d49cd5307bf8c572a8e99e57ddf83da88fad3587 Cr-Commit-Position: refs/heads/master@{#41030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/parsing/parser.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-11-16 09:35:39 UTC) #2
Camillo Bruni
PTAL
4 years, 1 month ago (2016-11-16 09:36:23 UTC) #4
Toon Verwaest
lgtm but you need an owner review :)
4 years, 1 month ago (2016-11-16 12:07:11 UTC) #5
Toon Verwaest
Turns out I am one. Amazing! :)
4 years, 1 month ago (2016-11-16 12:07:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504933002/1
4 years, 1 month ago (2016-11-16 12:08:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 12:33:43 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d49cd5307bf8c572a8e99e57ddf83da88fad3587
Cr-Commit-Position: refs/heads/master@{#41030}

Powered by Google App Engine
This is Rietveld 408576698