tools/determinism/compare_build_artifacts.py - Issue 2504903002: Should open file with 'w' to write a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/determinism/compare_build_artifacts.py

Issue 2504903002: Should open file with 'w' to write a file. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/determinism/compare_build_artifacts.py

diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py

index c19eccf7d523f5bc250a4df0caf8b55e93e720c7..0d78727156444e4e7b473a5272c1307191ba07cd 100755

--- a/tools/determinism/compare_build_artifacts.py

+++ b/tools/determinism/compare_build_artifacts.py

@@ -671,7 +671,7 @@ def compare_build_artifacts(first_dir, second_dir, target_platform,

'expected_diffs': expected_diffs,

'unexpected_diffs': unexpected_diffs,

}

- with open(json_output) as f:

+ with open(json_output, 'w') as f:

json.dump(out, f)

except Exception as e:

print('failed to write json output: %s' % e)

« no previous file with comments | « no previous file | no next file » | no next file with comments »