Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2504883003: Loading: move *StyleSheetResource to core/loader/resource (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, loading-reviews_chromium.org, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, loading-reviews+parser_chromium.org, pfeldman+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: move *StyleSheetResource to core/loader/resource To remove core/ dependency so that core/fetch can be moved under platform, move StyleSheetResource, StyleSheetResourceClient, CSSStyleSheetResource, and CSSStyleSheetResourceClient classes to core/loader/resource/. BUG=655920 Committed: https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a Cr-Commit-Position: refs/heads/master@{#435512}

Patch Set 1 #

Patch Set 2 : [rebase] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -579 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 1 chunk +0 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 1 1 chunk +0 lines, -234 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/fetch/StyleSheetResource.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/StyleSheetResource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/StyleSheetResourceClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
Takashi Toyoshima
4 years, 1 month ago (2016-11-16 07:32:09 UTC) #3
hiroshige
lgtm
4 years, 1 month ago (2016-11-17 06:31:37 UTC) #5
Takashi Toyoshima
yhirano: ptal, now this CL does not have a dependency.
4 years ago (2016-11-30 10:22:05 UTC) #9
Takashi Toyoshima
+kouhei for outside fetch and loader
4 years ago (2016-11-30 10:23:06 UTC) #11
kouhei (in TOK)
lgtm
4 years ago (2016-12-01 01:06:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504883003/20001
4 years ago (2016-12-01 01:07:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 01:14:34 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-01 01:17:52 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09057c54923af5745b85c30e86290643d0fdac7a
Cr-Commit-Position: refs/heads/master@{#435512}

Powered by Google App Engine
This is Rietveld 408576698