Issue 2504883002: Fix IE11 issue: this complements the CL I sent last week. It turns out that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2504883002: Fix IE11 issue: this complements the CL I sent last week. It turns out that (Closed)

Created:
4 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
4 years, 1 month ago

Reviewers:
jakemac, sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix IE11 issue: this complements the CL I sent last week. It turns out that there are two places where we do this check. This is why the test that I added appears to be failing in the bots. BUG= R=jakemac@google.com Committed: https://github.com/dart-lang/sdk/commit/d89dab56b54dfb6703ccb46bbb4a74e874ca3b5a

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -24 lines)			Patch
	M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+18 lines, -12 lines	0 comments	Download
	M	tools/dom/src/dart2js_CustomElementSupport.dart	View		3 chunks	+18 lines, -12 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

4 years, 1 month ago (2016-11-16 16:38:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
d89dab56b54dfb6703ccb46bbb4a74e874ca3b5a (presubmit successful).