Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2504863003: fix corpus tests (Closed)

Created:
4 years, 1 month ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

fix corpus tests All corpus tests draw reasonably well. There are pixel differences, but no missing features or large scale errors. This was verified by running run_corpus_tests.py on skiapaths and agg build dirs, then running the skdiff tool to generate a report of the pixel difference. For example, after running $ ninja -C out/skia skdiff $ ./out/skia/skdiff /repo/pdfium/out/agg/gen/pdfium/testing/corpus/ /repo/pdfium/out/skiapaths/gen/pdfium/testing/corpus/ ~/aggskiadiffs view the report in a browser at ~/aggskiadiffs/index.html R=dsinclair@chromium.org BUG=skia:5973 Committed: https://pdfium.googlesource.com/pdfium/+/0201377b6c4bb3b73f2564092426f3962a0bd9ed

Patch Set 1 #

Patch Set 2 : wip; this fixes nearly all corpus tests #

Patch Set 3 : all corpus tests draw reasonably well #

Patch Set 4 : merge with tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -90 lines) Patch
M core/fpdfapi/render/cpdf_renderstatus.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M core/fpdfapi/render/cpdf_renderstatus.cpp View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M core/fxge/cfx_fxgedevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M core/fxge/cfx_renderdevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/fxge/fx_dib.h View 2 chunks +10 lines, -1 line 0 comments Download
M core/fxge/ge/cfx_renderdevice.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.h View 3 chunks +8 lines, -2 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 2 48 chunks +169 lines, -86 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
caryclark
4 years, 1 month ago (2016-11-17 21:47:11 UTC) #9
dsinclair
I think you hit a conflict with some cleanup npm@ just committed.
4 years, 1 month ago (2016-11-17 21:57:12 UTC) #12
dsinclair
lgtm
4 years, 1 month ago (2016-11-18 01:27:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504863003/60001
4 years, 1 month ago (2016-11-18 01:27:55 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 01:28:13 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/0201377b6c4bb3b73f2564092426f3962a0b...

Powered by Google App Engine
This is Rietveld 408576698