Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2504813002: MD History: Remove unnecessary namespacing from tests (Closed)

Created:
4 years, 1 month ago by tsergeant
Modified:
4 years ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove unnecessary namespacing from tests (part 1) These tests followed the (outdated) practice of defining tests inside a dedicated `registerTests` function. This no longer has any benefit for isolating tests, and just reduces the amount of horizontal space available for test code. This CL only removes these registerTests functions and deindents the corresponding code -- there are no functional changes to any tests. BUG=647115 Committed: https://crrev.com/b3451f9f323fed4630432f989fa6c678089d96f8 Cr-Commit-Position: refs/heads/master@{#434433}

Patch Set 1 #

Patch Set 2 : Rebase? #

Patch Set 3 : Remove newlines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1359 lines, -1433 lines) Patch
M chrome/test/data/webui/md_history/history_item_test.js View 1 2 1 chunk +124 lines, -134 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 chunk +505 lines, -527 lines 0 comments Download
M chrome/test/data/webui/md_history/history_metrics_test.js View 1 chunk +189 lines, -202 lines 0 comments Download
M chrome/test/data/webui/md_history/history_overflow_menu_test.js View 1 chunk +58 lines, -66 lines 0 comments Download
M chrome/test/data/webui/md_history/history_supervised_user_test.js View 1 chunk +43 lines, -50 lines 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 chunk +440 lines, -448 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
tsergeant
PTAL. Sorry this is a nasty thing to review, but like the description says, there's ...
4 years ago (2016-11-21 04:30:10 UTC) #9
tsergeant
On 2016/11/21 04:30:10, tsergeant wrote: > PTAL. Sorry this is a nasty thing to review, ...
4 years ago (2016-11-25 00:44:17 UTC) #12
calamity
lgtm
4 years ago (2016-11-25 02:08:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504813002/40001
4 years ago (2016-11-25 02:45:39 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/277901)
4 years ago (2016-11-25 03:26:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504813002/40001
4 years ago (2016-11-25 03:38:07 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-25 04:36:39 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-25 04:39:07 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b3451f9f323fed4630432f989fa6c678089d96f8
Cr-Commit-Position: refs/heads/master@{#434433}

Powered by Google App Engine
This is Rietveld 408576698