Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 25048006: Attempt to clean up requiresLayoutToDetermineWidth to be more clear (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, tonyg, pdr.
Visibility:
Public.

Description

Attempt to clean up requiresLayoutToDetermineWidth to be more clear This code is brittle, and definitely wrong in some cases but hopefully this is more clear now. We need to find a path to making this more maintainable. Clearly this win is worth this complexity, we just need to figure out how to not have more bad regressions from this. BUG=247470 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158551

Patch Set 1 #

Patch Set 2 : MATCH THE CHUNKS HARDER #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +23 lines, -16 lines 3 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
7 years, 2 months ago (2013-09-27 20:47:16 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/25048006/diff/9001/Source/core/rendering/RenderBox.cpp File Source/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/25048006/diff/9001/Source/core/rendering/RenderBox.cpp#newcode413 Source/core/rendering/RenderBox.cpp:413: // FIXME: There are likely many subclasses of ...
7 years, 2 months ago (2013-09-30 16:28:06 UTC) #2
eseidel
7 years, 2 months ago (2013-09-30 23:20:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r158551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698