Support globalCompositeOperation in OffscreenCanvas

Support globalCompositeOperation in OffscreenCanvas

The implementation for this is already there, we just need to expose the
attribute DOMString globalCompositeOperation in the .idl file.

This CL makes this change and add a corresponding layout test.

BUG=645748
Committed: https://crrev.com/6f43a152b0ae1d78369da2b6ff25a1a1264653cf
Cr-Commit-Position: refs/heads/master@{#433248}

[xidachen, 2016-11-16 13:37:03]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, xlai@chromium.org

[xidachen, 2016-11-16 13:37:03]

PTAL

[xidachen, 2016-11-17 19:32:40]

On 2016/11/16 13:37:03, xidachen wrote:
> PTAL

gentle ping.

[Justin Novosad, 2016-11-17 19:34:24]

https://codereview.chromium.org/2504773003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html
(right):

https://codereview.chromium.org/2504773003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html:26:
assert_approx_equals(color[3], 255, 5);
This is not really a good test because the pixel value would be the same if you
did not set globalCompositeOperation (stayed in default source-over), so this
does not really verify the effect.

[xidachen, 2016-11-18 01:42:57]

https://codereview.chromium.org/2504773003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html
(right):

https://codereview.chromium.org/2504773003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html:26:
assert_approx_equals(color[3], 255, 5);
On 2016/11/17 19:34:24, Justin Novosad wrote:
> This is not really a good test because the pixel value would be the same if
you
> did not set globalCompositeOperation (stayed in default source-over), so this
> does not really verify the effect.

Done.

[xlai (Olivia), 2016-11-18 15:16:26]

https://codereview.chromium.org/2504773003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html
(right):

https://codereview.chromium.org/2504773003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html:18:
ctx1.globalCompositeOperation = 'source-in';
Hmmm, I think it's more important to test this function on worker rather than on
main, isn't it?

[Justin Novosad, 2016-11-18 15:30:24]

On 2016/11/18 15:16:26, xlai (Olivia) wrote:
>
https://codereview.chromium.org/2504773003/diff/60001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html
> (right):
> 
>
https://codereview.chromium.org/2504773003/diff/60001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-globalCompositeOperation.html:18:
> ctx1.globalCompositeOperation = 'source-in';
> Hmmm, I think it's more important to test this function on worker rather than
on
> main, isn't it?

For this feature, there is no real difference in code coverage for testing in
worker vs. main.

[Justin Novosad, 2016-11-18 15:30:38]

lgtm

[xidachen, 2016-11-18 15:31:25]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 15:32:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-11-18 18:21:18]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-11-18 18:21:40]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:22:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 18:40:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-18 18:43:42]

Description was changed from

==========
Support globalCompositeOperation in OffscreenCanvas

The implementation for this is already there, we just need to expose the
attribute DOMString globalCompositeOperation in the .idl file.

This CL makes this change and add a corresponding layout test.

BUG=645748
==========

to

==========
Support globalCompositeOperation in OffscreenCanvas

The implementation for this is already there, we just need to expose the
attribute DOMString globalCompositeOperation in the .idl file.

This CL makes this change and add a corresponding layout test.

BUG=645748

Committed: https://crrev.com/6f43a152b0ae1d78369da2b6ff25a1a1264653cf
Cr-Commit-Position: refs/heads/master@{#433248}
==========

[commit-bot: I haz the power, 2016-11-18 18:43:43]

Patchset 4 (id:??) landed as
https://crrev.com/6f43a152b0ae1d78369da2b6ff25a1a1264653cf
Cr-Commit-Position: refs/heads/master@{#433248}